evilny0/fpdb
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
3,023 Commits 1 Branch 0 Tags 14 MiB
8411f3ed09
Commit Graph

2733 Commits

Author SHA1 Message Date
Eratosthenes
8c1ce3df7d Merge branch 'master' of git://git.assembla.com/fpdboz 2010-02-03 11:17:10 -05:00
Worros
1cefb2e857 Fix playername siteid insert 
From Gerko on mailing list:
> I just did a trial. Use bulkimport for a single Pokerstars file
> switch setting and bulkimport a single Full tilt file.
> When screening the db all players in the database show the same siteId
> (2 for pokerstars)
> Or the other way if the first site was Full Tilt.

The Lambda function wasn't initialising the lambda function correctly.
 2010-02-03 23:48:39 +08:00
Eratosthenes
5c6d4e4744 Merge branch 'master' of git://git.assembla.com/fpdboz 2010-02-03 10:37:54 -05:00
Worros
33455cb1ac PokerStars: Fix tablename regex to allow a # 
Occasionally Stars throws up a cash table that looks like

PokerStars Game #22920951206:  Triple Draw 2-7 Lowball Limit ($0.10/$0.20) - 2008/12/14 17:44:00 ET
Table 'T #252691988' 6-max Seat #2 is the button

a # was previously excluded from the regex.
 2010-02-03 21:52:44 +08:00
Eratosthenes
7e5e9ed93a Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-02-03 08:40:16 -05:00
Eratosthenes
7aa67c38b1 Merge branch 'master' of git://git.assembla.com/fpdb-eric 2010-02-03 08:40:02 -05:00
sqlcoder
864454f31c change 2 commits to 1, may help sqlite stop locking up 2010-02-03 01:03:36 +00:00
sqlcoder
e3679a99fb fix steal calcs 2010-02-03 00:48:45 +00:00
sqlcoder
fece7c9147 move fpdb-error-log and HUD-error to APPDATA, renamed as fpdb-errors.txt and HUD-errors.txt to be consistent 2010-02-02 21:53:03 +00:00
Eric Blade
76f9517655 WinTables will no longer accept trying to attach to "FPDBHUD" titled windows 2010-02-02 14:54:27 -05:00
Eric Blade
e88d745e7d Merge branch 'master' of git://git.assembla.com/fpdb-sql.git 2010-02-02 10:51:22 -05:00
Eric Blade
6e30bb2067 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-02-02 10:48:17 -05:00
Eratosthenes
8c81761c1b Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-02-01 18:38:23 -05:00
Eratosthenes
aea7db22e3 Options for logging level and version. Not connected yet. 2010-02-01 18:37:36 -05:00
sqlcoder
96d0e0f181 fix key error and add filter to logging.conf 2010-02-01 22:56:40 +00:00
sqlcoder
d4248706e4 remove surplus get_logger calls, tidy up log messages some more 2010-02-01 22:31:00 +00:00
sqlcoder
86330e536a tidy up logging so that log isn't created in /fpdb/log/ unless it is being used 2010-02-01 21:03:51 +00:00
sqlcoder
7e5f63ce89 Merge branch 'master' of git://git.assembla.com/fpdboz 2010-02-01 19:49:57 +00:00
Eratosthenes
2a9c00953a Merge branch 'master' of git://git.assembla.com/fpdb-eric 2010-02-01 10:47:49 -05:00
Eratosthenes
03967fc227 Merge branch 'master' of git://git.assembla.com/fpdboz 2010-02-01 10:47:35 -05:00
Eratosthenes
f406ba293e Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-02-01 10:47:26 -05:00
Eric Blade
eff216919d Everleaf: Change "EUR"(old) to "EURO"(new), still doesn't seem to allow eur import (is that because my site config is set for usd ?) 2010-02-01 09:57:28 -05:00
Eric Blade
81ff8e632c remove my misunderstanding of how compileplayerregexs worked 2010-02-01 09:41:33 -05:00
Eric Blade
e3be7db2a0 fix bug i introduced that caused everleaf cash hands to fail 2010-02-01 09:17:42 -05:00
Eric Blade
1656a0e6d1 Everleaf: adjust Everleaf regexs to support tournaments, add error printing on failure of compilePlayerRegexs, add ring omahahilo pl and tour hold nl to supported games list, determine tournament number/table number from processing filename, fix getTableTitleRe 2010-02-01 08:51:06 -05:00
Eric Blade
27f95c51b2 whitespace 2010-02-01 08:48:28 -05:00
Eric Blade
9cf75f7303 fix getTableTitleRe calling in HUD_main:read_stdin, to use site_name (currently processing site name) instead of "site" which was always last site_name on list 
(this may break some people's HHC's, now that it works right)
 2010-02-01 08:47:55 -05:00
sqlcoder
a06aac6da8 correct case in SQL 2010-02-01 08:22:14 +00:00
Worros
12a9cd2e3e Fix case-sensitive MySQL tables on Linux 2010-02-01 16:06:09 +08:00
Worros
c46c4b05d4 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-02-01 16:04:17 +08:00
sqlcoder
9f3c5924b0 oops! missed out SQL.py from last release 2010-02-01 07:59:09 +00:00
Worros
6179823d92 Fix test harness after fpdb_db removal 2010-02-01 14:47:04 +08:00
Eratosthenes
428d228de8 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-01-31 22:56:01 -05:00
sqlcoder
e4c6419074 try to improve tourney handling in filter (now displays buyin, but this is not yet used by playerstats when fetching stats 2010-02-01 00:17:55 +00:00
sqlcoder
264b75b5b0 fix some sqlite and unicode issues (thanks to Gerko) 2010-01-31 23:46:51 +00:00
Eratosthenes
3102ff733f Merge branch 'master' of git://git.assembla.com/fpdb-eric 2010-01-31 14:16:39 -05:00
Eratosthenes
c7a9942f3a Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-01-31 14:16:21 -05:00
Eratosthenes
64bfa9cd52 Import mucked cards. 2010-01-31 13:37:59 -05:00
sqlcoder
002a84ba5a set rotating logs to max 5 files of 100MB each 2010-01-31 12:31:49 +00:00
sqlcoder
6f0ea2580b display dialog when .example config has been copied, this could work 'out-of-the-box' if the user already has gtk?? 2010-01-31 12:24:32 +00:00
sqlcoder
bbc84fef14 comment out debug message 2010-01-31 12:22:24 +00:00
sqlcoder
f7b402bcdb remove execute from permissions on some files in last commit 2010-01-31 11:27:37 +00:00
sqlcoder
5e9486aa3d config changes for logging: logs rotate and go to APPDATA, hud_config now goes in /fpdb/ if they must use it but logging.conf stays in /pyfpdb/. TODO: Some logging still into /fpdb/log/ 2010-01-31 11:25:24 +00:00
sqlcoder
cc5f77e950 fix windows problem starting hud 2010-01-31 11:16:42 +00:00
Eratosthenes
121d05596d Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-01-30 14:55:31 -05:00
Eratosthenes
6d9cdd9587 Fix problem where Qc is not encoded correctly. 2010-01-30 14:54:46 -05:00
sqlcoder
e0c5f52d0f uncommented sqlite unicode fix (fix only tested on Windows XP, cp1252) 2010-01-30 11:11:21 +00:00
sqlcoder
9932025271 move sqlite charset fix to Configuration.py from Database.py, make separate not_needed variables in Charset.py in case we want to update them separately 2010-01-30 11:05:34 +00:00
sqlcoder
d147187a71 add extra comment/suggestion 2010-01-29 23:36:39 +00:00
sqlcoder
a7d4c6243a add assignment (but commented out) that fixes unicode probs for me with sqlite 2010-01-29 23:29:37 +00:00
Eric Blade
72b890c561 add "HUD Test mode" checkbox to bulk import, doesn't currently do anything. intent is to make the program auto open a dummy window for a hud to attach to, so we can bulk import files to investigate hud issues 2010-01-29 17:45:49 -05:00
Eric Blade
f7ac36f3bb add getTableTitleRe to everleaf filter, doesn't seem to work 2010-01-29 17:44:58 -05:00
sqlcoder
2e970baa82 remove sqlite specific test to skip unicode encoding 2010-01-29 22:29:14 +00:00
Eric Blade
e56cb24ed1 to_utf8 returns what was passed in if unicode() errors because it's already encoded 2010-01-29 12:01:51 -05:00
Worros
23e0611978 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-01-29 17:20:57 +08:00
sqlcoder
52a176fd0a tidy up filter, add ability to refresh (eg after importing more gametypes) 2010-01-29 09:12:08 +00:00
Worros
a23d96e85d Add Carbon back in as default data. 
Also add PKR
 2010-01-29 17:00:37 +08:00
Worros
17bc9af88e Merge branch 'master' of git://github.com/kangaderoo/fpdb-kangaderoo 
Conflicts:
	run_fpdb.py
 2010-01-29 13:01:38 +08:00
Gerko de Roo
bacca69c49 Default graph created for empty data query 2010-01-29 12:33:15 +08:00
Eric Blade
e29491c25c use getpreferredencoding() instead of getdefaultlocale() to get LOCALE_ENCODING, default to cp1252 if it comes back with US-ASCII (Mac) 2010-01-28 20:29:43 -05:00
Eric Blade
725fb04bb8 Merge branch 'master' of git://git.assembla.com/fpdb-sql.git 
Conflicts:
	pyfpdb/Configuration.py
	pyfpdb/Database.py
 2010-01-28 16:28:23 -05:00
Eric Blade
f5d61b5bfc Merge branch 'master' of git://git.assembla.com/free_poker_tools.git 2010-01-28 16:25:47 -05:00
Eric Blade
8673cc3437 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-01-28 16:25:04 -05:00
Eratosthenes
7570db60f6 Make the StudMucked not crash with newimport. 2010-01-28 14:37:45 -05:00
Worros
28a7d1e353 Hopefully fully fix the FTP playername parsing. 
Split hand text for FTP, as the regex matches the player names incorrectly, and differentiating the lines is non-trivial.

The split should ensure that only the first version is available
 2010-01-28 23:38:52 +08:00
Worros
cee610d401 Add Carbon bits to example config file 2010-01-28 22:11:04 +08:00
Worros
ad75bedbf1 CarbonToFpdb.py - Converter for Carbon poker 
Currently only supports NLHE cash games. Further hand hstories required.

Plugin contributed by Matthew Boss.
 2010-01-28 21:36:02 +08:00
Eric Blade
3381527afc raise FpdbHandDuplicate error on duplicate insert attempt, catch it in import_file_dict, increment duplicates count 2010-01-28 05:56:17 -05:00
Eric Blade
d36ac3f927 rename DuplicateError to FpdbHandDuplicate, add matching FpdbHandError and FpdbHandPartial (not sure where to implement catching those though) 2010-01-28 05:55:06 -05:00
Eric Blade
2be8b9d33b get fpdb icon from absolute path instead of relative to cwd 2010-01-28 05:19:39 -05:00
Eric Blade
997483f909 make import timer work again 2010-01-28 05:19:19 -05:00
Eric Blade
803fcec6dc make hud_main call with full path in windows, as has been done in unix 2010-01-28 04:45:33 -05:00
Worros
7c90102677 Preliminary Carbon functions. 
- Add the SITEID for Carbon

- Add function addAllIn():
"For sites which record "all in" as a special action, which can mean either "calls and is all in" or "raises all in".
"
 2010-01-28 15:13:49 +08:00
Eratosthenes
92e20bcd12 Add more chars to player name in prev commit. 2010-01-27 23:16:11 -05:00
Eratosthenes
d50e70fdd4 Another fix of FTP playername reg ex. 2010-01-27 20:10:07 -05:00
sqlcoder
1df418c8e4 create fpdb dir if required, improve sqlite performance :-) 2010-01-27 23:48:39 +00:00
Worros
a9f2a261d4 Regex fix for Fulltilt player names 
"Seat 7: moletrapper collected ($2.50)"
vs
"Seat 7: moletrapper ($2.50)"

The regex update should match the second and not the first.
 2010-01-28 01:44:14 +08:00
Gerko de Roo
6f78749ebd Default graph created for empty data query 2010-01-27 18:37:23 +01:00
Worros
cd05c1da48 Remove unused variable 2010-01-28 01:36:42 +08:00
Gerko de Roo
92b5a43a22 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-01-27 16:46:45 +01:00
Eratosthenes
2ad7e430a2 Merge branch 'master' of git://git.assembla.com/fpdboz 2010-01-27 09:49:14 -05:00
Eratosthenes
2adf0158a4 Merge branch 'master' of git://git.assembla.com/fpdb-sql 
Conflicts:
	pyfpdb/Database.py
	pyfpdb/PartyPokerToFpdb.py
 2010-01-27 09:48:31 -05:00
Eratosthenes
080b7f80c9 Compile the " collected" reg ex. 2010-01-27 09:23:12 -05:00
Worros
929e182a28 FulltiltToFpdb: Fix tourney player matching for players sitting out 2010-01-27 18:20:48 +08:00
Worros
8dea509245 FulltiltToFpdb: partially fix player ids 
_mysql_exceptions.IntegrityError: (1062, "Duplicate entry 'romatrifon (small blind) showed -1' for key 'name'")

Previous regex was matching past the name.
 2010-01-27 18:02:30 +08:00
sqlcoder
e82d276cf9 pull and merge from carl (nothing changed) 2010-01-27 08:56:51 +00:00
Eratosthenes
d75e5e3920 Fixed typos, pylint complaints, and obsolete TODOs. 2010-01-27 01:10:58 -05:00
Eratosthenes
30de5142db Ugly fix to ugly edge case where winner voluntarily showed cards. 2010-01-27 00:57:58 -05:00
Eratosthenes
e0d11fe9a3 Fix problem with finding HHs for utf-16 files. 2010-01-27 13:10:50 +08:00
Gerko de Roo
6c5c479ee8 Autocomplete Hero names only lists the valid names for that pokersite 
SiteID list needed to be filled before the Hero field was filled.
 2010-01-27 13:04:21 +08:00
Worros
fb7aae9186 clean-up code to get playerId in gui-stats and gui-graphs 
Conflicts:

	pyfpdb/GuiGraphViewer.py
 2010-01-27 13:04:13 +08:00
Gerko de Roo
241dc1e717 Fixed limit and freeroll support for Partypoker tourney's 2010-01-27 11:33:15 +08:00
Eratosthenes
1ec6a36ece Merge branch 'master' of git://git.assembla.com/fpdb-sql 
Conflicts:
	pyfpdb/Configuration.py
	pyfpdb/Database.py
 2010-01-26 20:13:21 -05:00
sqlcoder
5a9836862f sqlite mods, made sqlite the default in HUD_config.xml.example - works (roughly) straight out of the box 2010-01-27 00:48:02 +00:00
sqlcoder
11bc48e126 merge fpdb_db.py into Database.py 2010-01-26 23:54:04 +00:00
sqlcoder
47baee65f9 add tourneyid to hands table (REQUIRES REIMPORT) and fix sqlite db access 2010-01-26 22:46:48 +00:00
Gerko de Roo
f5c910bff0 clean-up code to get playerId in gui-stats and gui-graphs 2010-01-26 23:36:38 +01:00
Gerko de Roo
b248270135 Sorting routine caused errors when sorted on gametype, 
since it used the starthand sort routine
 2010-01-26 23:34:08 +01:00
sqlcoder
de2b807c9b refine hud_config handling some more (copies .exmaple to proper dir) 2010-01-26 21:54:58 +00:00
sqlcoder
5c88c6b0ad put database directory next to HUD_config.xml file 2010-01-26 21:02:37 +00:00
Mika Bostrom
ff9305924c Use proper encoding name 
When system is unicode, the second item in locale.getdefaultlocale() is
"UTF8", not "utf-8".
 2010-01-26 20:31:11 +01:00
Gerko de Roo
88cf6ec3a5 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-01-26 20:29:19 +01:00
Gerko de Roo
4814c30d8f Autocomplete Hero names only lists the valid names for that pokersite 
SiteID list needed to be filled before the Hero field was filled.
 2010-01-26 20:25:04 +01:00
Gerko de Roo
12c93ea9a6 Support for same hero name on multiple sites also implemented in GuiGraph 2010-01-26 20:20:17 +01:00
Eratosthenes
7d7ba94da1 Fix problem with finding HHs for utf-16 files. 2010-01-26 10:56:07 -05:00
Mika Bostrom
7f04ed88f4 Use proper encoding name 
When system is unicode, the second item in locale.getdefaultlocale() is
"UTF8", not "utf-8".
 2010-01-26 08:01:46 +02:00
Eratosthenes
7683590898 Merge branch 'master' of git://git.assembla.com/fpdboz 
Conflicts:
	pyfpdb/Configuration.py
 2010-01-25 12:06:11 -05:00
Eratosthenes
90ea33c74b Needs to be executable. 2010-01-25 12:04:21 -05:00
Mika Bostrom
12367d6f37 Merge branch 'master' of git://git.assembla.com/fpdboz 2010-01-25 19:03:21 +02:00
Worros
896de37d0d Fix hudCache update semantics 2010-01-26 01:00:22 +08:00
Mika Bostrom
b58edb53ae Write charmap-related errors directly to stderr 
This change is needed to skip a nasty behaviour: if the string triggered
a decoding error, it will trigger one *AGAIN* if the string is printed
to console. By writing directly to sys.stderr we skip the
locale/conversion issues and get the troublesome string directly in a
file where it is stored as a raw sequence of octets.
 2010-01-24 21:28:08 +01:00
Mika Bostrom
2c7287c351 Add new encoder 
This encoder is used to handle input from HH conversion, which needs to
end up as UTF-8 in the database. Switch the open-coded routine from
Database.py to this common routine so all encodings now take place in
the same file.
 2010-01-24 21:27:40 +01:00
Mika Bostrom
860b5737b7 Use common encoding routine everywhere 
The string/locale manipulation in Database.py was open-coded and did not
use Charset.to_utf8() like the rest of the code.
 2010-01-24 21:27:35 +01:00
Mika Bostrom
85c9070ec8 Write charmap-related errors directly to stderr 
This change is needed to skip a nasty behaviour: if the string triggered
a decoding error, it will trigger one *AGAIN* if the string is printed
to console. By writing directly to sys.stderr we skip the
locale/conversion issues and get the troublesome string directly in a
file where it is stored as a raw sequence of octets.
 2010-01-24 22:17:03 +02:00
Mika Bostrom
33277ce68b Add new encoder 
This encoder is used to handle input from HH conversion, which needs to
end up as UTF-8 in the database. Switch the open-coded routine from
Database.py to this common routine so all encodings now take place in
the same file.
 2010-01-24 21:11:46 +02:00
Mika Bostrom
6dcec48005 Use common encoding routine everywhere 
The string/locale manipulation in Database.py was open-coded and did not
use Charset.to_utf8() like the rest of the code.
 2010-01-24 19:59:49 +02:00
Gerko de Roo
73ae88e47a Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-01-24 13:37:27 +01:00
Worros
dbaad2d430 Remove NEWIMPORT variable. 
No going back now :)
 2010-01-24 13:36:21 +01:00
Mika Bostrom
c36c60155c Use a different "unicoder" for db strings 
It seems that running encoder.encode() on a latin1/latin9 string results
in, yes a bloody UnicodeDecodeError. Decode error on .encode()...
Really. This way the modification from non-unicode string to real
unicode appears to work better.
 2010-01-24 13:35:10 +01:00
Worros
fde2f1f710 Fix Charset import got Grapher 2010-01-24 13:30:02 +01:00
Mika Bostrom
cc3811b8aa Add missing import 
GuiPlayerStats.py didn't import the new Charset module but tried to use
the functions.
 2010-01-24 13:24:26 +01:00
Gerko de Roo
7737720aa8 Conflicts: 
pyfpdb/Charset.py
 2010-01-23 16:35:57 +01:00
Mika Bostrom
3a03bc51a2 Some character set improvements 
The strings (names) as stored in database should always be UTF-8;
whatever the display locale is, we then need to convert from the storage
encoding to session encoding. When making database queries with players
names in them, the names must be reconverted to UTF-8.
 2010-01-23 16:34:24 +01:00
Gerko de Roo
53153bd00a Fixed limit and freeroll support for Partypoker tourney's 2010-01-23 16:32:32 +01:00
Gerko de Roo
81b9b51707 HUD fix for tournaments. Table name storage. 2010-01-23 23:18:39 +08:00
Gerko de Roo
b888f82a53 All game selection boxes default enabled 2010-01-23 23:05:40 +08:00
Gerko de Roo
6cb956c5fd HUD fix for tournaments. Table name storage. 2010-01-23 11:17:14 +01:00
Gerko de Roo
9100ba814c All game selection boxes default enabled 2010-01-23 10:01:36 +01:00
Worros
9d6707f18f Fix Charset import got Grapher 2010-01-23 15:30:48 +08:00
Worros
2538f61906 Remove erronous comment 2010-01-23 15:22:22 +08:00
Worros
74115dcd47 Fix comment layout - had a \t 2010-01-23 15:20:17 +08:00
Worros
6b38976edc Add left-2click option to hide stat windows. 
Gerko, so I assume others don't have a middle mouse button.
 2010-01-23 14:38:53 +08:00
Gerko de Roo
d3f17f3fb7 game selector for graphs added. 
exception caught for games selector for player stats
 2010-01-23 14:34:34 +08:00
Worros
29e705f337 Remove NEWIMPORT variable. 
No going back now :)
 2010-01-23 13:37:41 +08:00
Eratosthenes
358de81f3b Merge branch 'master' of git://git.assembla.com/fpdboz 
Conflicts:
	pyfpdb/Configuration.py
	pyfpdb/Database.py
 2010-01-22 20:55:13 -05:00
Gerko de Roo
3cd51ca990 Added freeroll support for Pokerstars 2010-01-22 23:42:44 +01:00
Worros
98e4b598ed Merge branch 'master' of git://repo.or.cz/fpbd-bostik 2010-01-23 02:18:42 +08:00
Worros
c88ccd1140 Remove unused convert_cards() 2010-01-23 02:18:20 +08:00
Gerko de Roo
261daf6003 game selector for graphs added. 
exception caught for games selector for player stats
 2010-01-22 18:36:21 +01:00
Gerko de Roo
fdc5a0a635 Added close on double click for a stat window 
Just in case you don't have a mouse with middle button
 2010-01-22 15:38:33 +01:00
Mika Bostrom
9aa52ce6a8 Merge branch 'master' of git://git.assembla.com/fpdboz 
Conflicts:
	pyfpdb/Card.py

Resolve by removing stray empty lines
 2010-01-22 09:24:19 +02:00
Gerko de Roo
4ada389f86 Changed the card positions and mucked card 
positions to relative positions.
 2010-01-21 21:14:49 +01:00
Mika Bostrom
91cd2d2599 Remove erroneous encoding 
This string should not be encoded, it seems.
 2010-01-21 22:05:24 +02:00
Mika Bostrom
29d5204bee Add missing import 
GuiPlayerStats.py didn't import the new Charset module but tried to use
the functions.
 2010-01-21 21:52:22 +02:00
Mika Bostrom
04c345ae1f Use a different "unicoder" for db strings 
It seems that running encoder.encode() on a latin1/latin9 string results
in, yes a bloody UnicodeDecodeError. Decode error on .encode()...
Really. This way the modification from non-unicode string to real
unicode appears to work better.
 2010-01-21 21:46:14 +02:00
Mika Bostrom
dd12da302d Merge branch 'good' 
Conflicts:
	pyfpdb/test_PokerStars.py

Resolve by copying sorrow's version on top-
 2010-01-21 21:34:54 +02:00
Mika Bostrom
dda00b6b10 Catch character encoding errors 2010-01-21 21:31:19 +02:00
Mika Bostrom
a841603460 Some character set improvements 
The strings (names) as stored in database should always be UTF-8;
whatever the display locale is, we then need to convert from the storage
encoding to session encoding. When making database queries with players
names in them, the names must be reconverted to UTF-8.
 2010-01-21 21:24:55 +02:00
Mika Bostrom
e915b0b62c Allow to bypass codec 
If the system (display) locale is UTF-8, there is no need to encode to
either direction. In fact, running the .encode() routine appears to
mangle a valid UTF-8 string to a worse condition, effectively breaking
it.
 2010-01-21 21:23:13 +02:00
Gerko de Roo
eb6e60f578 New 'master' clone of git://git.assembla.com/fpdboz.git 2010-01-21 19:15:25 +01:00
Mika Bostrom
34bf2bd8e9 Use better function name 2010-01-21 18:12:45 +02:00
unknown
ea423f6b2c added a game selector to the player stats. 2010-01-21 14:14:24 +08:00
Worros
4187561e66 Whitespace fixes to Card.py 2010-01-21 14:12:17 +08:00
Gerko de Roo
ef4f5289bb Solved some merge issues --> Cards.py 
Issues Pokerstars when playing heads-up on ring games,
   being both on button and small blind now supported
   !!if not solved the winnings of the (button, small blind) is stored as rake!!
Post both small and big blind when re-entering ring games solved
 2010-01-21 14:07:46 +08:00
Mika Bostrom
cd71778975 Fix name display in HUD popup 
The names are stored in UTF-8, so simply converting the name from UTF-8
to Configuration.LOCALE_ENCODING before putting the string in tooltip is
enough. Neat.
 2010-01-21 13:56:50 +08:00
sqlcoder
41877097c9 fix twostartcards to handle 22 and unknowns properly 2010-01-21 13:49:45 +08:00
Mika Bostrom
7ec58ad5c2 Fix name display in HUD popup 
The names are stored in UTF-8, so simply converting the name from UTF-8
to Configuration.LOCALE_ENCODING before putting the string in tooltip is
enough. Neat.
 2010-01-19 19:26:31 +02:00
Mika Bostrom
cb172e15ae Fix name display in HUD popup 
The names are stored in UTF-8, so simply converting the name from UTF-8
to Configuration.LOCALE_ENCODING before putting the string in tooltip is
enough. Neat.
 2010-01-19 19:25:36 +02:00
Mika Bostrom
7f568a52b9 Merge branch 'newstats' into good 2010-01-16 13:56:20 +02:00
Worros
3f0dfd2b26 Fix enumerate() 2010-01-16 13:55:01 +08:00
Eratosthenes
98e6566fc6 Merge branch 'master' of git://git.assembla.com/fpdb-eric 2010-01-15 11:58:50 -05:00
Eratosthenes
4460f19608 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2010-01-15 11:58:39 -05:00
Eratosthenes
3f9fce0775 Merge branch 'master' of git://git.assembla.com/fpdboz 
Conflicts:
	pyfpdb/PartyPokerToFpdb.py
 2010-01-15 11:58:27 -05:00
Worros
776405982b Quick fix for hud 2010-01-15 21:24:37 +08:00
Worros
5c0d695055 [NEWIMPORT] Almost all remaining stats 
All conversions from Grigorij

street0_3BChance
street0_3BDone
street0_4BChance
street0_4BDone
stealAttemptChance
stealAttempted
foldBbToStealChance
foldBbToStealChance
foldSbToStealChance
foldedSbToSteal
foldedBbToSteal

3Bet, 4Bet in Stud does appear to work.

Unable to test steal in Stud games, all example hands in micros do not have a chance (I believe)
 2010-01-15 20:07:50 +08:00
Worros
150b1891d6 [NEWIMPORT] setPositions(), fix aggr function 
PFR now actually works
 2010-01-15 20:04:59 +08:00
Worros
95aa993903 [NEWIMPORT] setPositions(), fix aggr function 
PFR now actually works
 2010-01-15 20:03:26 +08:00
Worros
ecf1c6b878 [NEWIMPORT] Almost all remaining stats 
All conversions from Grigorij

street0_3BChance
street0_3BDone
street0_4BChance
street0_4BDone
stealAttemptChance
stealAttempted
foldBbToStealChance
foldBbToStealChance
foldSbToStealChance
foldedSbToSteal
foldedBbToSteal

3Bet, 4Bet in Stud does appear to work.

Unable to test steal in Stud games, all example hands in micros do not have a chance (I believe)
 2010-01-15 19:42:24 +08:00
Worros
700a68bcc8 [NEWIMPORT] calcCheckCallRaise() 
Modify function from Grigorij to calculate check/call
 2010-01-15 18:29:16 +08:00
Worros
bad744fd80 [NEWIMPORT] setPositions(), fix aggr function 
PFR now actually works
 2010-01-15 13:50:46 +08:00
sqlcoder
012b5bc72c fix twostartcards to handle 22 and unknowns properly 2010-01-13 23:40:25 +02:00
sqlcoder
6594431277 fix twostartcards to handle 22 and unknowns properly 2010-01-12 22:10:59 +00:00
sqlcoder
62935664c8 set stats color to fgcolor 2010-01-02 11:05:58 +08:00
Eric Blade
1287ab95e7 stupid windows git newline mangling 2010-01-01 20:53:27 -05:00
Eric Blade
798ce94c48 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2010-01-01 20:53:07 -05:00
sqlcoder
8cb73b822c set stats color to fgcolor 2010-01-01 22:57:25 +00:00
Worros
cd88de7c7e [NEWIMPORT] Copy in Alchemy files from Grigorij's alchemy branch 2009-12-30 15:44:48 +08:00
Mika Bostrom
478b82587d Store names as UTF-8 
The names should be always in UTF-8 encoding. At least for PostgreSQL
the encdoding of the database comes from the time of running 'initdb'
(which is different from 'createdb') and if the encoding was selected or
set to something else at that time, the following error will occur:

  File ".../pyfpdb/Database.py", line 1630, in <lambda>
    self.pcache = LambdaDict(lambda  key:self.insertPlayer(key, siteid))
  File ".../pyfpdb/Database.py", line 1661, in insertPlayer
    c.execute (q, (site_id, _name))
  File "/usr/lib/python2.5/encodings/iso8859_15.py", line 12, in encode
    return codecs.charmap_encode(input,errors,encoding_table)
UnicodeEncodeError: 'charmap' codec can't encode character u'\u2122' in
position 10: character maps to <undefined>

This happens because 'name' is a regular string as opposed to a valid
unicode object. By forcing the string to unicode and encoding it in
UTF-8 the error goes away. In my case the database encoding was
ISO-8859-15 (latin9) but any other "wrong" encoding would trigger the
same problem.

This is a relatively common problem in python.
 2009-12-29 13:05:03 +08:00
Worros
4800f2515f Update HUD_config.xml 
- Change default Holdem stat window layout to 3x3, add some more colouring
- Fix tab breakage from Gerko.
 2009-12-28 22:09:06 +08:00
Worros
c7aca0a32e Update HUD_config.xml 
- Change default Holdem stat window layout to 3x3, add some more colouring
- Fix tab breakage from Gerko.
 2009-12-28 22:03:26 +08:00
Gerko de Roo
1cf464283f Hmm forgot the color reset to default. 
There must be a better methode
 2009-12-28 10:41:22 +08:00
Gerko de Roo
6efccd9067 Hmm forgot the color reset to default. 
There must be a better methode
 2009-12-28 10:41:04 +08:00
Worros
3f3d8ac54a Fix tab spacing from Gerkos recent patch 2009-12-28 10:22:44 +08:00
Worros
805d35c3fd Fix tab spacing from Gerkos recent patch 2009-12-28 10:21:31 +08:00
Gerko de Roo
eb226c0026 Added color highlight for stats window. 
high and low threshold and color can be set in the xml file
 2009-12-28 10:17:01 +08:00
Gerko de Roo
2cd57e826d Added color highlight for stats window. 
high and low threshold and color can be set in the xml file
 2009-12-28 10:16:48 +08:00
Gerko de Roo
3553bdaf71 search string for table detect changed 2009-12-28 10:14:04 +08:00
Gerko de Roo
f66b8307d3 search string for table detect changed 2009-12-28 10:04:33 +08:00
Worros
0e318e6d9f [NEWIMPORT] Commit currnetly failing test - sawShowdown 
It would appear that all-in pre-flop doesn't flag sawShowdown.

Also modified the query to select street0Aggr, as that appears to be wrong at the moment
 2009-12-26 17:18:05 +08:00
Worros
9f2f015fd0 New test for all-in preflop. 
Test still fails - need to sort out an issue with database placement
 2009-12-26 12:25:05 +08:00
Worros
1245a0cab3 New test file - All-in pre flop 2009-12-26 12:24:41 +08:00
Worros
624ab07f85 New test for all-in preflop. 
Test still fails - need to sort out an issue with database placement
 2009-12-26 12:23:20 +08:00
Worros
1bcb6736eb New test file - All-in pre flop 2009-12-26 10:07:33 +08:00
Worros
46e91e1a0f [NEWIMPORT] Remove a couple of unused functions 2009-12-25 18:55:13 +08:00
Worros
0adf0a7b18 [NEWIMPORT] updateHudCache update. 
Fix a couple of bugs:
    position != 2 its = 'M'
    actually commit changes to hud
 2009-12-24 01:12:39 +08:00
Worros
a0475aa4db [NEWIMPORT] Add function to update hudcache for Hand 2009-12-23 23:14:34 +08:00
Worros
a2d0657b3a [NEWIMPORT] Remove unused functions 
Move old HudCache update over in preparation for fixing
 2009-12-23 13:56:18 +08:00
Worros
6e9153c25c [NEWIMPORT] Copy Grigorij's code from Alchemy 
Copied some of Grigorij's code verbatim for calculating additional stats, still needs adapting.

Also reorder some functions so the corresponding files are more mergeable in future.
 2009-12-23 13:30:12 +08:00
Eric Blade
932695b40f Merge branch 'master' of git://git.assembla.com/fpdboz.git 2009-12-22 13:36:52 -05:00
Worros
355225fc25 [NEWIMPORT] Remove test_fpdb_simple 2009-12-22 23:03:05 +08:00
Worros
d8a87b92d4 [NEWIMPORT] Make hudcache rebuild only happen no call to hud 2009-12-22 22:15:27 +08:00
Worros
284693e95e [NEWIMPORT] Rebuild hudcache after hand is committed 2009-12-22 22:02:36 +08:00
Worros
4d8d678d64 [NEWIMPORT] Make seek into autoimport function 
Now that the legacy import path is gone, enable the index for HHC
 2009-12-22 21:40:37 +08:00
Worros
ae55a89d7f Remove reference to fpdb_simple 2009-12-22 20:22:05 +08:00
Worros
0898ddf8a1 [NEWIMPORT] HandsPlayers.startCards 
Dodgy function just to get things kinda working again.
 2009-12-22 17:30:49 +08:00
Worros
a3be99bcf6 [NEWIMPORT] HandsPlayers.startCards 
Dodgy function just to get things kinda working again.
 2009-12-22 17:20:07 +08:00
Worros
1b82f20411 [NEWIMPORT] Remove legacy code. 2009-12-22 14:44:35 +08:00
Worros
262eb5200d Add LOCALE static to Configuration 2009-12-22 13:49:22 +08:00
Worros
02453ce3c0 Move locale variable to Configuration 2009-12-22 13:47:33 +08:00
Worros
af1b516b23 Merge branch 'master' into stats 
Conflicts:
	pyfpdb/DerivedStats.py
	pyfpdb/fpdb_import.py
 2009-12-22 13:47:26 +08:00
Worros
b71e485252 PokerStarsToFpdb - Add comment on parsing tourney buy-in 2009-12-21 16:10:44 +08:00
Worros
7b7865e794 Merge branch 'master' of git://git.assembla.com/fpdb 2009-12-21 11:16:25 +08:00
Worros
babf0a039a PartyPoker - No Disconnect fix 
Fix from Neko on 2+2

http://forumserver.twoplustwo.com/showpost.php?p=15495528&postcount=2374

"Finally got around to checking this out. Seems great so far. I had issues with some of my party hands that were on No Disconnect protect tables but adding the No DP regex in the PartyToFpdb hand converter seems to have fixed it for me."
 2009-12-21 09:21:41 +08:00
steffen123
d5608fa7a7 support PS tourneys with euro buyin 2009-12-20 12:01:26 +00:00
Eric Blade
6683967091 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2009-12-19 04:31:16 -05:00
Eratosthenes
a12e9fe1b2 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-18 21:41:44 -05:00
Worros
d5de93da28 [NEWIMPORT] Syntax fix 2009-12-19 10:07:53 +08:00
Worros
9012c74db7 [NEWIMPORT] Fix syntax to be 2.5 compatible. 
Python 2.6 enumerate() function contains a useful 'start' paramater,
apparently this did not exist in 2.5.

Patch frim Mika Bostrom
 2009-12-18 13:33:56 +08:00
Worros
2b7d34c484 [NEWIMPORT] Fix syntax to be 2.5 compatible. 
Python 2.6 enumerate() function contains a useful 'start' paramater,
apparently this did not exist in 2.5.

Patch frim Mika Bostrom
 2009-12-18 13:32:09 +08:00
Worros
a2947c8707 [NEWIMPORT] Add stubbed variable to insert 2009-12-18 10:28:28 +08:00
Worros
975eb360ef [NEWIMPORT] Add stubbed variable to insert 2009-12-18 10:27:43 +08:00
Worros
1093b1e43c Remove dead code 2009-12-18 10:27:09 +08:00
Worros
ba8f61d14a Add ability to import Stars archive files. 
PokerStars support can provide a HH archive. The format is similar but not the same as a a standard hh format as it contains an additional line "Hand #X" between each hand.

Patch adds an option -s to GuiBulkImport, which when specified will strip these lines out and continue parsing.
 2009-12-17 18:50:40 +08:00
Worros
26fc0b5928 Add ability to import Stars archive files. 
PokerStars support can provide a HH archive. The format is similar but not the same as a a standard hh format as it contains an additional line "Hand #X" between each hand.

Patch adds an option -s to GuiBulkImport, which when specified will strip these lines out and continue parsing.
 2009-12-17 18:42:50 +08:00
Eric Blade
b25dedbf5e Merge branch 'master' of git://git.assembla.com/fpdboz.git 2009-12-17 04:07:25 -05:00
Worros
22f98ab1c5 Add some code to kinda detect hand cancellation 
hhc.readHandInfo(self)
hhc.readPlayerStacks(self)
hhc.compilePlayerRegexs(self)
hhc.markStreets(self)

Is the order, the first correctly failing regex is markStreets
 2009-12-17 16:00:24 +08:00
Worros
1fb99e4595 Add test hand - Hand cancelled 2009-12-17 15:59:29 +08:00
Worros
f03a9c287f Add some code to kinda detect hand cancellation 
hhc.readHandInfo(self)
hhc.readPlayerStacks(self)
hhc.compilePlayerRegexs(self)
hhc.markStreets(self)

Is the order, the first correctly failing regex is markStreets
 2009-12-17 15:53:12 +08:00
Worros
209c4f94fa Merge branch 'master' into stats 2009-12-17 13:33:39 +08:00
Worros
f7616c6ee8 [NEWIMPORT] Move hud call to after database commit 
HUD still doesn't quite work, but getting closer - suspect hud_cache rebuild isn't happening
 2009-12-17 02:24:57 +08:00
Worros
1f70a9ad8a [NEWIMPORT] Fix thinko on insertPlayer 
Was returning the player name instead of id in the case where the player exists in the database, but wasn't cached already

Removing some merge gunge too
 2009-12-17 01:55:48 +08:00
Worros
80c324c8e1 [NEWIMPORT] Add a commit at the end of the fpdb_import cycle 2009-12-17 00:40:36 +08:00
Worros
5c0323c842 Add PartyPoker 10 seat hud layout to example file 2009-12-17 00:12:53 +08:00
Worros
826ca4b2c7 [NEWIMPORT] 'correct' the type for wonWhenSeenStreet1 2009-12-16 23:11:08 +08:00
Worros
52d1ce1402 [NEWIMPOR] Fix insert type for wonAtSD 2009-12-16 22:58:54 +08:00
Worros
c50addf867 [NEWIMPORT] Fix startCash fix 2009-12-16 22:48:38 +08:00
Worros
353fec235f [NEWIMPORT] Convert start stack to cents 2009-12-16 22:41:48 +08:00
Worros
1d53196568 Fix loal variable scope bug 
Never have been quite sure of local variable scope using python indentation, this didn't appear to affect anyone until a poster on 2+2
 2009-12-16 20:04:10 +08:00
Worros
be0cb6fc2a Fix a couple of typos 2009-12-15 22:56:18 +08:00
Eric Blade
7ca08899c5 Merge branch 'master' of git://git.assembla.com/fpdboz.git 2009-12-15 06:08:30 -05:00
Worros
a18b3a9cfb Merge branch 'master' into stats 2009-12-14 19:03:23 +08:00
Worros
4746ddb33d Fix thinko in stub 2009-12-14 19:03:01 +08:00
Worros
2ca866398f Merge branch 'master' into stats 2009-12-14 18:02:08 +08:00
Worros
56c5521e6a [NEWIMPORT] Move HandsPlayers insert statement into SQL.py 2009-12-14 18:01:24 +08:00
Worros
fb92ee2941 [NEWIMPORT] Stub remaining HandsPlayers stats 2009-12-14 17:52:08 +08:00
Carl Gherardi
7d45d40d16 Merge branch 'master' of git://repo.or.cz/fpbd-bostik 2009-12-14 16:47:10 +08:00
Carl Gherardi
6b45723b09 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-14 16:46:57 +08:00
Carl Gherardi
cf6e818ae5 [NEWIMPORT] Enable NEWIMPORT by defaul 2009-12-14 16:45:08 +08:00
Eratosthenes
0592b1c2c0 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-13 12:38:17 -05:00
Mika Bostrom
20de6fe730 Clean up about window 
Remove duplicates
 2009-12-13 16:12:29 +02:00
sqlcoder
69168ff868 unwind change that stopped mysawshowdown being set unless all-in (which I hardly ever am, since I play limit ... so my WtSD was displaying as 0) 2009-12-13 12:57:46 +00:00
sqlcoder
05d0d02df4 reload profile after editing Prefs if no other tabs are open, otherwise suggest restart 2009-12-13 12:55:15 +00:00
Carl Gherardi
e08afeecb1 [NEWIMPORT] Move database prep into prepInsert 2009-12-13 13:48:17 +08:00
Carl Gherardi
40cbb55f7f [NEWIMPORT] Enable printInsert, disable hud pipe 2009-12-13 13:47:14 +08:00
sqlcoder
4cc1c4cfe6 add name to nodes 2009-12-12 12:09:58 +00:00
sqlcoder
c7e11a8cc3 default guiprefs window to larger size 2009-12-12 12:08:48 +00:00
sqlcoder
ab89f9f603 show message dialog if pg connect fails 2009-12-12 09:51:07 +00:00
Mika Bostrom
fcf14f9100 Merge own master 2009-12-10 06:47:13 +02:00
Mika Bostrom
835fc98f6f Cosmetic fix 
About -> Credits takes a list of strings in .set_authors() as opposed to
a single string. Now the credit popup looks about right.
 2009-12-10 06:41:15 +02:00
Eric Blade
e221c9c0f6 Merge branch 'master' of git://git.assembla.com/fpdb-sql.git 2009-12-09 21:36:34 -05:00
Eratosthenes
ea60cda961 Merge branch 'master' of git://git.assembla.com/fpdb-eric 2009-12-09 20:25:44 -05:00
Eratosthenes
e85608ee52 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-09 20:25:36 -05:00
Eratosthenes
bb9f5553ce Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-09 20:25:25 -05:00
sqlcoder
fc95de82f4 logviewer: avoid memory-mapped files, make it work when opened a second time 2009-12-09 21:58:56 +00:00
Eric Blade
5e7bd33cd0 no changes here 2009-12-08 17:48:52 -05:00
sqlcoder
bbaecc1697 add package version info to About dialog 2009-12-08 22:17:55 +00:00
sqlcoder
50e63a8131 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-07 22:55:32 +00:00
sqlcoder
68835dd9b8 tidy up log viewer some more 2009-12-07 22:55:12 +00:00
Worros
09b0e02c37 Add Makefile and a couple of test HH's 2009-12-07 12:14:19 +08:00
Worros
5f67fc8220 Merge branch 'master' of git://git.assembla.com/fpdb-eric 2009-12-07 12:10:56 +08:00
Worros
a3192e77f2 Merge branch 'master' of git://repo.or.cz/fpbd-bostik 2009-12-07 12:10:43 +08:00
Worros
49576b5eb3 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-07 12:09:05 +08:00
Worros
cd5b5b468c Forgot to add actual test file 2009-12-07 12:07:43 +08:00
Worros
0061bd0644 [NEWIMPORT] Add call to HUD for auto import 
Make sure the matching db_handid is recorded in the Hand object for later use
 2009-12-06 23:02:07 +08:00
Worros
909c2bd0fc Add test for Stars sawShowdown. 
Test currently fails in the old import code and passes on NEWIMPORT

Tests for uncalled allin bet on river, which has been erronously marked as showdown previously
 2009-12-06 22:57:27 +08:00
Worros
8f787b2d44 Make test file use real database. 
Please note this could be destructive
 2009-12-06 22:56:29 +08:00
Worros
4d38488f26 [NEWIMPORT] Fix sawShowdown stat 2009-12-06 22:52:45 +08:00
sqlcoder
63f04908be add simple test scripts for python and gtk 2009-12-06 14:17:22 +00:00
Mika Bostrom
128fa2f356 Enclose dict key lookup in try-except block 
Some recent changes moved the dictionary access outside try-except block
again. Widen the block enough again.
 2009-12-06 14:08:27 +02:00
Eratosthenes
c3c36e1e53 Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-05 19:16:42 -05:00
Eratosthenes
b483686019 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-05 19:16:36 -05:00
sqlcoder
66b4ed35e5 add refresh button to log viewer 2009-12-05 22:48:41 +00:00
sqlcoder
18b0a47555 move print message to log 2009-12-05 22:20:44 +00:00
sqlcoder
85242f13cb fix bug with hud stats, must use ORDER BY in the selects 2009-12-05 21:59:42 +00:00
sqlcoder
2934c32132 limit number of lines displayed in log viewer 2009-12-05 20:31:37 +00:00
sqlcoder
2d8c44110c refine log viewer 2009-12-05 20:10:00 +00:00
sqlcoder
72303bf900 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-05 15:55:06 +00:00
sqlcoder
6826d0157a create gui option to view the log 2009-12-05 15:54:49 +00:00
Worros
61840e73c6 Add beginings of test for sawShowdown - unfinished. 
Some sort of weird commit problem going on. Conmmitiing to work on htat
 2009-12-05 20:18:47 +08:00
Worros
c40d665700 Newimport - comments for a getPosition function. 
Decided that I needed some test functions before I kick on
 2009-12-05 20:15:28 +08:00
Eratosthenes
a1bdf68dc2 Merge branch 'master' of git://github.com/grindi/fpdb-grindi 2009-12-04 12:16:38 -05:00
Eratosthenes
2863edf1df Merge branch 'master' of git://git.assembla.com/fpdb-eric 2009-12-04 12:16:26 -05:00
Eratosthenes
193944799d Merge branch 'master' of git://git.assembla.com/fpdb-sql 2009-12-04 12:16:17 -05:00
Eratosthenes
6987cf6584 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-04 12:16:10 -05:00
Worros
ee205c3b29 [NEWIMPORT] Partially fix number of hands parsed reporting 2009-12-04 17:56:56 +08:00
sqlcoder
c9b9927315 fix new timing code so it actually works\! 2009-12-03 21:02:05 +00:00
sqlcoder
cd65aae374 allow legend box to work in python 2.5 2009-12-03 20:20:42 +00:00
sqlcoder
9dd09fe8a1 Merge branch 'master' of git://git.assembla.com/fpdboz 2009-12-03 20:14:12 +00:00
Eric Blade
6195397c88 fix typos.. durrr 2009-12-03 12:52:57 -05:00
Eric Blade
adadb7defa slight optimizations 2009-12-03 12:51:10 -05:00