From 39f5b9095c237ffa38f483ebe3f280c83119abb8 Mon Sep 17 00:00:00 2001 From: steffen123 Date: Thu, 7 Aug 2008 00:17:51 +0100 Subject: [PATCH] git14 - finished one .expected for the HUD data table. seems to reveal a total of 5 errors - ouch changed range of tv-activeSeats on user feedback - will do this occasionally until i make it configurable "fix": "imp/tv bug: handcount is only about 1/2 of what it should be" -> this was NOT a bug. I was just a bit silly and didn't connect the dots from activating a filter by number of active players and the sudden drop of hands. --- docs/known-bugs-and-planned-features.txt | 27 ++++++++++-------- pyfpdb/fpdb.py | 2 +- pyfpdb/table_viewer.py | 2 +- regression-test/ps-flags-3hands.expected.txt | 30 ++++++++++++++++++++ regression-test/regression-test.sh | 2 +- 5 files changed, 48 insertions(+), 15 deletions(-) create mode 100644 regression-test/ps-flags-3hands.expected.txt diff --git a/docs/known-bugs-and-planned-features.txt b/docs/known-bugs-and-planned-features.txt index be64ebaf..0e3b56c5 100644 --- a/docs/known-bugs-and-planned-features.txt +++ b/docs/known-bugs-and-planned-features.txt @@ -2,10 +2,11 @@ todolist (db=database, imp=importer, tv=tableviewer) before alpha ============ -colour in tv -verify at least one PrintPlayerFlags -in tv, select from hud table using named fields rather than the current * -imp/tv bug: handcount is only about 1/2 of what it should be +verify at least two PrintPlayerFlags (one of them with 10+ hands) +fix fold % in tv +optionally show single postflop agg/fold rate + +colour in tv, or at least seperation lines add stud functionality back to imp/tv db+imp+tv WtSD (went to showdown) db+imp+tv W$SD (won $ when seeing showdown - partial win counts partially here) @@ -13,21 +14,22 @@ db+imp+tv WwSF (Won when seen flop - partial taken into account) change action_no to be total for this street rather than just for one player properly read 3B/4B percentage -fix load profile fix tv browse button size -tourney bug: sometimes truncuates position on store -> possibly indicates much bigger problem -tourney bug: fails recognisePlayer -tourney bug: fails with tuple error in recogniseplayerid -config wizard catch index error, type error, file not found error -update install instructions +update install instructions, include how to adapt default config and where to put it split python requirements, get deep links for windows DL for everything implement error file in importer -remove mysql/myisam support. -ideally HUD before beta =========== +in tv, select from hud table using named fields rather than the current * +remove remains of mysql/myisam support. +tourney bug: sometimes truncuates position on store -> possibly indicates much bigger problem +tourney bug: fails recognisePlayer +tourney bug: fails with tuple error in recogniseplayerid +fix load profile +HUD +config wizard file permission script, use games group change stud street storage from 3-7 to 0-4 throughout make bulk importer display a grand total in the GUI @@ -46,6 +48,7 @@ verify at least 2 or 3 sng hands no rush but before 1.0RC ======================== +move version into seperate file HTMLify docs and validate them cut down action_types array size to appropriate length make tv work with ftp e.g. by making importer return site as well (easy) diff --git a/pyfpdb/fpdb.py b/pyfpdb/fpdb.py index 30f306a0..5b30882c 100755 --- a/pyfpdb/fpdb.py +++ b/pyfpdb/fpdb.py @@ -343,7 +343,7 @@ blabla""") self.window = gtk.Window(gtk.WINDOW_TOPLEVEL) self.window.connect("delete_event", self.delete_event) self.window.connect("destroy", self.destroy) - self.window.set_title("Free Poker DB - version: pre-alpha, git13") + self.window.set_title("Free Poker DB - version: pre-alpha, git14") self.window.set_border_width(1) self.window.set_size_request(700,400) self.window.set_resizable(True) diff --git a/pyfpdb/table_viewer.py b/pyfpdb/table_viewer.py index 958dddea..58280909 100755 --- a/pyfpdb/table_viewer.py +++ b/pyfpdb/table_viewer.py @@ -75,7 +75,7 @@ class table_viewer (threading.Thread): if seatCount>=8: minSeats,maxSeats=7,10 elif seatCount==7: - minSeats,maxSeats=6,9 + minSeats,maxSeats=6,10 elif seatCount==6 or seatCount==5: minSeats,maxSeats=seatCount-1,seatCount+1 elif seatCount==4: diff --git a/regression-test/ps-flags-3hands.expected.txt b/regression-test/ps-flags-3hands.expected.txt new file mode 100644 index 00000000..cf491638 --- /dev/null +++ b/regression-test/ps-flags-3hands.expected.txt @@ -0,0 +1,30 @@ +Connected to MySQL on localhost. Print Player Flags Utility + +Basic Data +========== +bigblind: 2 category: holdem limitType: fl name: Player_1 gameType: ring site: PokerStars +siteId: 2 gametypeId: 1 playerId: 1 hudDataId: 1 + +HUD Raw Hand Counts +=================== +HDs: 3 +VPIP: 1 +PFR: 0 +PF3B4BChance: 1 +PF3B4B: 0 + +sawFlop: 1 +sawTurn: 1 +sawRiver: 1 +sawShowdown: 0 + +raisedFlop: 0 +raisedTurn: 0 +raisedRiver: 0 + +otherRaisedFlop: 1 +otherRaisedFlopFold: 0 +otherRaisedTurn: 1 +otherRaisedTurnFold: 0 +otherRaisedRiver: 1 +otherRaisedRiverFold: 1 diff --git a/regression-test/regression-test.sh b/regression-test/regression-test.sh index cd8fa5df..309e0469 100755 --- a/regression-test/regression-test.sh +++ b/regression-test/regression-test.sh @@ -30,7 +30,7 @@ echo "it should've reported first that it stored 3, then that it had 3 duplicate ./print_hand.py -p$1 --hand=14519420999 > ps.14519420999.found.txt && colordiff ps.14519420999.found.txt ps.14519420999.expected.txt ./print_hand.py -p$1 --hand=14519433154 > ps.14519433154.found.txt && colordiff ps.14519433154.found.txt ps.14519433154.expected.txt -./PrintPlayerFlags.py -p$1 > ps-flags-3hands.found.txt && colordiff ps-flags-3hands.found.txt ps-flags-3hands.expected.txt +./PrintPlayerHudData.py -p$1 > ps-flags-3hands.found.txt && colordiff ps-flags-3hands.found.txt ps-flags-3hands.expected.txt #./print_hand.py -p$1 --site="Full Tilt Poker" --hand=6367428246 > ftp.6367428246.found.txt && colordiff ftp.6367428246.found.txt ftp.6367428246.expected.txt