From b26f4a09ce03d068617b17d1d964141a041b8e41 Mon Sep 17 00:00:00 2001
From: Eric Blade <blade.eric@gmail.com>
Date: Sun, 16 Aug 2009 04:22:22 -0500
Subject: [PATCH 1/5] Absolute: support Pot Limit and Fixed Limit ("Normal" as
 they call it) Configuration: Only trap the thrown error when checking for
 existence of site default paths, if not found set path to a reasonable ERROR
 message instead of "default"

---
 pyfpdb/AbsoluteToFpdb.py | 4 ++--
 pyfpdb/Configuration.py  | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pyfpdb/AbsoluteToFpdb.py b/pyfpdb/AbsoluteToFpdb.py
index e8ac53ff..796e5e6e 100644
--- a/pyfpdb/AbsoluteToFpdb.py
+++ b/pyfpdb/AbsoluteToFpdb.py
@@ -41,7 +41,7 @@ class Absolute(HandHistoryConverter):
 #Seat 6 - FETS63 ($0.75 in chips)
 #Board [10s 5d Kh Qh 8c]
 
-    re_GameInfo     = re.compile(ur"^Stage #([0-9]+): (?P<GAME>Holdem|)  (?P<LIMIT>No Limit|) (?P<CURRENCY>\$| €|)(?P<BB>[0-9]*[.0-9]+)", re.MULTILINE)
+    re_GameInfo     = re.compile(ur"^Stage #([0-9]+): (?P<GAME>Holdem|)  (?P<LIMIT>No Limit|Pot Limit|Normal) (?P<CURRENCY>\$| €|)(?P<BB>[0-9]*[.0-9]+)", re.MULTILINE)
     re_HandInfo     = re.compile(ur"^Stage #(?P<HID>[0-9]+): .*(?P<DATETIME>\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d).*\nTable: (?P<TABLE>.*) \(Real Money\)", re.MULTILINE)
     re_Button       = re.compile(ur"Seat #(?P<BUTTON>[0-9]) is the ?[dead]* dealer$", re.MULTILINE) # TODO: that's not the right way to match for "dead" dealer is it?
     re_PlayerInfo   = re.compile(ur"^Seat (?P<SEAT>[0-9]) - (?P<PNAME>.*) \((?:\$| €|)(?P<CASH>[0-9]*[.0-9]+) in chips\)", re.MULTILINE)
@@ -112,7 +112,7 @@ or None if we fail to get the info """
         mg = m.groupdict()
         
         # translations from captured groups to our info strings
-        limits = { 'No Limit':'nl', 'PL':'pl', '':'fl' }
+        limits = { 'No Limit':'nl', 'Pot Limit':'pl', 'Normal':'fl' }
         games = {              # base, category
                   "Holdem" : ('hold','holdem'), 
                     'Omaha' : ('hold','omahahi'), 
diff --git a/pyfpdb/Configuration.py b/pyfpdb/Configuration.py
index f0277bca..4da9f22d 100755
--- a/pyfpdb/Configuration.py
+++ b/pyfpdb/Configuration.py
@@ -311,7 +311,7 @@ class Config:
         try:
             print "Reading configuration file %s\n" % (file)
             doc = xml.dom.minidom.parse(file)
-        except:
+        except: 
             print "Error parsing %s.  See error log file." % (file)
             traceback.print_exc(file=sys.stderr)
             print "press enter to continue"
@@ -596,8 +596,8 @@ class Config:
             path = os.path.expanduser(self.supported_sites[site].HH_path)
             assert(os.path.isdir(path) or os.path.isfile(path)) # maybe it should try another site?
             paths['hud-defaultPath'] = paths['bulkImport-defaultPath'] = path
-        except:
-            paths['hud-defaultPath'] = paths['bulkImport-defaultPath'] = "default"
+        except AssertionError: 
+            paths['hud-defaultPath'] = paths['bulkImport-defaultPath'] = "** ERROR DEFAULT PATH IN CONFIG DOES NOT EXIST **"
         return paths
     
     def get_frames(self, site = "PokerStars"):

From aa0610dcfacd278724f496786822baa09175eaba Mon Sep 17 00:00:00 2001
From: Eric Blade <blade.eric@gmail.com>
Date: Sun, 16 Aug 2009 04:46:41 -0500
Subject: [PATCH 2/5] fpdb: remove error trap on "Recreate Tables" menu option
 - trapping should be much more localized.

---
 pyfpdb/fpdb.py | 43 ++++++++++++++++++++-----------------------
 1 file changed, 20 insertions(+), 23 deletions(-)

diff --git a/pyfpdb/fpdb.py b/pyfpdb/fpdb.py
index 23bb4495..08c1eca2 100755
--- a/pyfpdb/fpdb.py
+++ b/pyfpdb/fpdb.py
@@ -243,30 +243,27 @@ class fpdb:
         if self.obtain_global_lock():  # returns true if successful
 
             #lock_released = False
-            try:
-                dia_confirm = gtk.MessageDialog(parent=None, flags=0, type=gtk.MESSAGE_WARNING,
-                        buttons=(gtk.BUTTONS_YES_NO), message_format="Confirm deleting and recreating tables")
-                diastring = "Please confirm that you want to (re-)create the tables. If there already are tables in the database " \
-                            +self.db.fdb.database+" on "+self.db.fdb.host+" they will be deleted."
-                dia_confirm.format_secondary_text(diastring)#todo: make above string with bold for db, host and deleted
+            dia_confirm = gtk.MessageDialog(parent=None, flags=0, type=gtk.MESSAGE_WARNING,
+                    buttons=(gtk.BUTTONS_YES_NO), message_format="Confirm deleting and recreating tables")
+            diastring = "Please confirm that you want to (re-)create the tables. If there already are tables in the database " \
+                        +self.db.fdb.database+" on "+self.db.fdb.host+" they will be deleted."
+            dia_confirm.format_secondary_text(diastring)#todo: make above string with bold for db, host and deleted
 
-                response = dia_confirm.run()
-                dia_confirm.destroy()
-                if response == gtk.RESPONSE_YES:
-                    #if self.db.fdb.backend == self.fdb_lock.fdb.MYSQL_INNODB:
-                        # mysql requires locks on all tables or none - easier to release this lock 
-                        # than lock all the other tables
-                        # ToDo: lock all other tables so that lock doesn't have to be released
-                    #    self.release_global_lock()
-                    #    lock_released = True
-                    self.db.recreate_tables()
-                    #else:
-                        # for other dbs use same connection as holds global lock
-                    #    self.fdb_lock.fdb.recreate_tables()
-                elif response == gtk.RESPONSE_NO:
-                    print 'User cancelled recreating tables'
-            except:
-                pass
+            response = dia_confirm.run()
+            dia_confirm.destroy()
+            if response == gtk.RESPONSE_YES:
+                #if self.db.fdb.backend == self.fdb_lock.fdb.MYSQL_INNODB:
+                    # mysql requires locks on all tables or none - easier to release this lock 
+                    # than lock all the other tables
+                    # ToDo: lock all other tables so that lock doesn't have to be released
+                #    self.release_global_lock()
+                #    lock_released = True
+                self.db.recreate_tables()
+                #else:
+                    # for other dbs use same connection as holds global lock
+                #    self.fdb_lock.fdb.recreate_tables()
+            elif response == gtk.RESPONSE_NO:
+                print 'User cancelled recreating tables'
             #if not lock_released:
             self.release_global_lock()
     #end def dia_recreate_tables

From d495606f2ae4a4378b02968f6d1cd4c0d146b42a Mon Sep 17 00:00:00 2001
From: Eric Blade <blade.eric@gmail.com>
Date: Sun, 16 Aug 2009 05:30:11 -0500
Subject: [PATCH 3/5] GuiAutoImport:  do_import: change label of Stop button
 when running an import, to provide a visual indicator  startClicked: refactor
 so only the Pipe Open is inside the exception handler, since that should be
 the only thing in there that we need to ignore an exception from.

---
 pyfpdb/GuiAutoImport.py | 54 +++++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 23 deletions(-)

diff --git a/pyfpdb/GuiAutoImport.py b/pyfpdb/GuiAutoImport.py
index b1815e95..80272e93 100755
--- a/pyfpdb/GuiAutoImport.py
+++ b/pyfpdb/GuiAutoImport.py
@@ -136,12 +136,19 @@ class GuiAutoImport (threading.Thread):
     def do_import(self):
         """Callback for timer to do an import iteration."""
         if self.doAutoImportBool:
+            self.startButton.set_label(u' I M P O R T I N G  ')
             self.importer.runUpdated()
             sys.stdout.write(".")
             sys.stdout.flush()
+            gobject.timeout_add(1000, self.reset_startbutton)
             return True
         else:
             return False
+        
+    def reset_startbutton(self):
+        self.startButton.set_label(u'  _Stop Autoimport  ')
+        return False
+
 
     def startClicked(self, widget, data):
         """runs when user clicks start on auto import tab"""
@@ -161,33 +168,34 @@ class GuiAutoImport (threading.Thread):
             # - Ideally we want to release the lock if the auto-import is killed by some 
             # kind of exception - is this possible?
             if self.settings['global_lock'].acquire(False):   # returns false immediately if lock not acquired
-                try:
-                    print "\nGlobal lock taken ..."
-                    self.doAutoImportBool = True
-                    widget.set_label(u'  _Stop Autoimport  ')
-                    if self.pipe_to_hud is None:
-                        if os.name == 'nt':
-                            command = "python HUD_main.py" + " " + self.settings['cl_options']
-                            bs = 0    # windows is not happy with line buffing here
-                            self.pipe_to_hud = subprocess.Popen(command, bufsize = bs, stdin = subprocess.PIPE, 
-                                                            universal_newlines=True)
-                        else:
-                            command = os.path.join(sys.path[0],  'HUD_main.py')
-                            cl = [command, ] + string.split(self.settings['cl_options'])
-                            self.pipe_to_hud = subprocess.Popen(cl, bufsize = 1, stdin = subprocess.PIPE, 
-                                                            universal_newlines=True)
-
-                        # Add directories to importer object.
+                print "\nGlobal lock taken ..."
+                self.doAutoImportBool = True
+                widget.set_label(u'  _Stop Autoimport  ')
+                if self.pipe_to_hud is None:
+                    if os.name == 'nt':
+                        command = "python HUD_main.py " + self.settings['cl_options']
+                        bs = 0
+                    else:
+                        command = os.path.join(sys.path[0], 'HUD_main.py')
+                        command = [command, ] + string.split(self.settings['cl_options'])
+                        bs = 1
+                    try:
+                        self.pipe_to_hud = subprocess.Popen(command, bufsize = bs, stdin = subprocess.PIPE,
+                                                            universal_newlines = True)
+                    except:
+                        err = traceback.extract_tb(sys.exc_info()[2])[-1]
+                        print "*** Error: " + err[2] + "(" + str(err[1]) + "): " + str(sys.exc_info()[1])
+                    
+                    print "self.pipe_to_hud = ", self.pipe_to_hud
+                    if self.pipe_to_hud is not None:
                         for site in self.input_settings:
                             self.importer.addImportDirectory(self.input_settings[site][0], True, site, self.input_settings[site][1])
-                            print "Adding import directories - Site: " + site + " dir: "+ str(self.input_settings[site][0])
+                            print "+Import directory - Site: " + site + " dir: " + str(self.input_settings[site][0])
                             self.do_import()
-
-                            interval=int(self.intervalEntry.get_text())
+                            
+                            interval = int(self.intervalEntry.get_text())
                             gobject.timeout_add(interval*1000, self.do_import)
-                except:
-                    err = traceback.extract_tb(sys.exc_info()[2])[-1]
-                    print "***Error: "+err[2]+"("+str(err[1])+"): "+str(sys.exc_info()[1])
+                        
             else:
                 print "auto-import aborted - global lock not available"
         else: # toggled off

From 8bba1fd9321fd32eabf7f84406f50d78ee1104ac Mon Sep 17 00:00:00 2001
From: Eric Blade <blade.eric@gmail.com>
Date: Sun, 16 Aug 2009 07:32:56 -0500
Subject: [PATCH 4/5] structured Exceptions a bit more like most python apps
 seem to do it (and as suggested in the manual)

---
 pyfpdb/Exceptions.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pyfpdb/Exceptions.py b/pyfpdb/Exceptions.py
index 8259a484..0b7e5691 100644
--- a/pyfpdb/Exceptions.py
+++ b/pyfpdb/Exceptions.py
@@ -1,4 +1,7 @@
-class FpdbParseError(Exception): 
+class FPDBError(Exception):
+    pass
+
+class FpdbParseError(FPDBError): 
     def __init__(self,hid=None):
         self.hid = hid
 

From 9f893408812e5b3a4fa36cfe2f5650d470e45707 Mon Sep 17 00:00:00 2001
From: Eric Blade <blade.eric@gmail.com>
Date: Sun, 16 Aug 2009 14:30:52 -0500
Subject: [PATCH 5/5] timeout in startbutton reset resets to Stop or Start as
 appropriate

---
 pyfpdb/GuiAutoImport.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/pyfpdb/GuiAutoImport.py b/pyfpdb/GuiAutoImport.py
index 80272e93..77e7fbdc 100755
--- a/pyfpdb/GuiAutoImport.py
+++ b/pyfpdb/GuiAutoImport.py
@@ -146,7 +146,11 @@ class GuiAutoImport (threading.Thread):
             return False
         
     def reset_startbutton(self):
-        self.startButton.set_label(u'  _Stop Autoimport  ')
+        if self.pipe_to_hud is not None:
+            self.startButton.set_label(u'  _Stop Autoimport  ')
+        else:
+            self.startButton.set_label(u'  _Start Autoimport  ')
+        
         return False
 
 
@@ -185,9 +189,7 @@ class GuiAutoImport (threading.Thread):
                     except:
                         err = traceback.extract_tb(sys.exc_info()[2])[-1]
                         print "*** Error: " + err[2] + "(" + str(err[1]) + "): " + str(sys.exc_info()[1])
-                    
-                    print "self.pipe_to_hud = ", self.pipe_to_hud
-                    if self.pipe_to_hud is not None:
+                    else:                    
                         for site in self.input_settings:
                             self.importer.addImportDirectory(self.input_settings[site][0], True, site, self.input_settings[site][1])
                             print "+Import directory - Site: " + site + " dir: " + str(self.input_settings[site][0])